Jump to content

Welcome to Geeks to Go - Register now for FREE

Need help with your computer or device? Want to learn new tech skills? You're in the right place!
Geeks to Go is a friendly community of tech experts who can solve any problem you have. Just create a free account and post your question. Our volunteers will reply quickly and guide you through the steps. Don't let tech troubles stop you. Join Geeks to Go now and get the support you need!

How it Works Create Account
Photo

Critisize my website

Started by comanighttrain , Oct 26 2008 02:29 PM

  • Please log in to reply

#1
comanighttrain
Posted 26 October 2008 - 02:29 PM

comanighttrain

    Member

  • Member
  • PipPipPip
  • 553 posts
Hey guys, this site has grown!!

Im just putting this up to see if anyone with 5 mins to spare can check and give me advice on my site?

Its not fully built, but the forum, pages and tutorial 1 are available.

Its totally free, no membership, ads and im not selling anything.

The website is a help site for students and intends to teach the basics of problem solving and programming to help students (or people who just want to program) how-to!

Computing Student Site

- whoops, can someone move me!

Edited by comanighttrain, 26 October 2008 - 02:34 PM.

  • 0

Advertisements

#2
Major Payne
Posted 26 October 2008 - 06:24 PM

Major Payne

    Retired Staff

  • Retired Staff
  • 5,307 posts
OK, here goes:

1) No character encoding listed
2) tables used for layout of pages yet you set DocType for XHTML 1.0 which is a cut above table tag coders. Tables went out in late 1990s when CSS and use of div tags came in.
3) Image of you on pages looks a little distorted.
4) On contact page I suggest you "munge" your email address to hide it from spam bots. Might just do the entire address bit.
5) Should code semantically as well as syntactically.
6) Need to add some meta tags for Search Engines.
7) Could center entire pages and header/logo.

Overall a clean site with very few coding errors. Came close to passing validation for HTML coding. CSS did.
  • 0

#3
comanighttrain
Posted 26 October 2008 - 06:28 PM

comanighttrain

    Member

  • Topic Starter
  • Member
  • PipPipPip
  • 553 posts

OK, here goes:

1) No character encoding listed
2) tables used for layout of pages yet you set DocType for XHTML 1.0 which is a cut above table tag coders. Tables went out in late 1990s when CSS and use of div tags came in.
3) Image of you on pages looks a little distorted.
4) On contact page I suggest you "munge" your email address to hide it from spam bots. Might just do the entire address bit.
5) Should code semantically as well as syntactically.
6) Need to add some meta tags for Search Engines.
7) Could center entire pages and header/logo.

Overall a clean site with very few coding errors. Came close to passing validation for HTML coding. CSS did.


Thanks :)

Did you notice why my tutorial 1 doesnt work with firefox? the Javascript is fine on Opera and IE but not firefox
  • 0

#4
Major Payne
Posted 26 October 2008 - 06:42 PM

Major Payne

    Retired Staff

  • Retired Staff
  • 5,307 posts
Just what are you seeing in IE that you don't see in Firefox? Got to your Tut 1 page in FF and IE 8 the same one. Page layout is slightly cramped for the input boxes in IE as compared to FF. On Tutorial 1 you have this: 
<body>

	<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
which may be confusing some browsers. Might check the other pages of tuts to see if you have the DocType after the opening body tag.

Edited by Major Payne, 26 October 2008 - 06:43 PM.

  • 0

#5
comanighttrain
Posted 26 October 2008 - 06:48 PM

comanighttrain

    Member

  • Topic Starter
  • Member
  • PipPipPip
  • 553 posts
If you click submit you should get a pop telling you if you have successfully completed the questionnaire. In FF nothing appears and i get an error saying

"Error: questionOne is not defined
Source File: http://www.davidbatt...s/Tutorial1.htm
Line: 16"

However in both opera and IE7 the submit button works fine
  • 0

#6
comanighttrain
Posted 26 October 2008 - 07:22 PM

comanighttrain

    Member

  • Topic Starter
  • Member
  • PipPipPip
  • 553 posts
for anyone else reading, i found this on XHTML Layouts http://joey101.net/2...d-xhtml-layout/
  • 0

#7
Major Payne
Posted 26 October 2008 - 08:42 PM

Major Payne

    Retired Staff

  • Retired Staff
  • 5,307 posts
And they might want to read: Why tables for layout is stupid

Additional Sources

Edited by Major Payne, 26 October 2008 - 08:43 PM.

  • 0

#8
Major Payne
Posted 26 October 2008 - 08:49 PM

Major Payne

    Retired Staff

  • Retired Staff
  • 5,307 posts

If you click submit you should get a pop telling you if you have successfully completed the questionnaire. In FF nothing appears and i get an error saying

"Error: questionOne is not defined
Source File: http://www.davidbatt...s/Tutorial1.htm
Line: 16"

However in both opera and IE7 the submit button works fine

You are not using any <form></form> tags is probably the problem. Firefox is the only compliant browsers to HTML 4.01/CSS 2.1 standards. IE and others are just too sloppy to care how your code is and will parse your page and usually function ok. Doesn't mean they are right, but it does make them very popular with people who write sloppy code.
  • 0

#9
comanighttrain
Posted 30 October 2008 - 05:42 PM

comanighttrain

    Member

  • Topic Starter
  • Member
  • PipPipPip
  • 553 posts
I started recoding my site, its going pretty well, it even looks better!

but uhh....what about the tutorials page? is that an acceptable table or can it be arranged in a similar way using CSS and XHTML
  • 0

#10
Major Payne
Posted 30 October 2008 - 08:35 PM

Major Payne

    Retired Staff

  • Retired Staff
  • 5,307 posts
Content text that goes full width is hard on a readers eyes. Should keep eye span within around 12% from left to right. Form could be laid out a little more orderly. Not sure what you meant about tables, but congrats on getting yout page to validate XHTML 1.0 Strict. Just one CSS error.
  • 0

Advertisements

#11
comanighttrain
Posted 30 October 2008 - 08:39 PM

comanighttrain

    Member

  • Topic Starter
  • Member
  • PipPipPip
  • 553 posts
12% you say? ill fire that in tommorrow.

My Quiz now works on ze firefox browser:D

just had to use

document.getElementById()

instead of just referencing the Element directly (which makes more sense to a Java dev! *shakes fist at firefox*)

thanks for the help:)
  • 0

#12
comanighttrain
Posted 30 October 2008 - 09:09 PM

comanighttrain

    Member

  • Topic Starter
  • Member
  • PipPipPip
  • 553 posts
meh...i didnt go to sleep and did that instead...
  • 0

#13
Major Payne
Posted 30 October 2008 - 09:14 PM

Major Payne

    Retired Staff

  • Retired Staff
  • 5,307 posts
12% is just a ballpark figure. The less a reader's eyes has to scan from left to right or vice-versa, the easier it is on the eyes and more likely they'll spend more time reading the content. This goes hand-in-hand with proper contrasting of font color versus background color and font family/size.
  • 0

#14
comanighttrain
Posted 30 October 2008 - 09:16 PM

comanighttrain

    Member

  • Topic Starter
  • Member
  • PipPipPip
  • 553 posts
know any good resources on that stuff?

I always wondered why some tutorials were better than others. . .
  • 0

#15
Major Payne
Posted 30 October 2008 - 10:04 PM

Major Payne

    Retired Staff

  • Retired Staff
  • 5,307 posts
I'm sure some one has tutorials online, but I've just picked up the knowledge in all the time I've been coding pages. Even my own site gets hit with criticism at times, but I just never seem to find time to correct a lot of things that should be corrected.
  • 0
Back to Web Development · Next Unread Topic →




Similar Topics

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users

  1. Geeks to Go Community
  2. → Development
  3. → Web Development

As Featured On:

Microsoft Yahoo BBC MSN PC Magazine Washington Post HP