[stettybet0]

Hi, I'm trying to write a batch file that runs under XP. Here it is (slightly modified to take out long bits of unimportant echoing)

@echo off
echo Welcome
echo Press Y or N
choice /C:YN
if errorlevel 1 goto yes
if errorlevel 2 goto no
:yes
echo You pressed Y!
pause
goto quit
:no
echo You pressed N!
pause
goto quit
:quit
exit

Okay, now at first the "choice" wouldn't work at all, so I downloaded CHOICE.COM from Microsoft, and now it works. However, no matter whether I press Y or N, it goes to "yes"! Why won't it go to "no"?

Thanks,
stettybet0

[Advertisements]

Errorlevel values need to be checked in reverse order, more so under XP than any other version of DOS.

The safest way to use errorlevels for all DOS versions is the reverse order check.
Start checking the highest errorlevel that can be expected, then check for the one below, etcetera:

IF ERRORLEVEL 255 GOTO Label255
IF ERRORLEVEL 254 GOTO Label254

	*
	*
	*

IF ERRORLEVEL 2 GOTO Label2
IF ERRORLEVEL 1 GOTO Label1
GOTO Label0 

:Label255
(commands to be executed at errorlevel 255)
GOTO End

	*
	*
	*

:Label1
(commands to be executed at errorlevel 1)
GOTO End

:Label0
(commands to be executed at errorlevel 0, or no errorlevel)

:End

This will result in many more lines of batch code, but at least it will work in any DOS version.

See http://www.robvander...errorlevel.html for more details.

[Neil Jones]

Errorlevel values need to be checked in reverse order, more so under XP than any other version of DOS.

The safest way to use errorlevels for all DOS versions is the reverse order check.
Start checking the highest errorlevel that can be expected, then check for the one below, etcetera:

IF ERRORLEVEL 255 GOTO Label255
IF ERRORLEVEL 254 GOTO Label254

	*
	*
	*

IF ERRORLEVEL 2 GOTO Label2
IF ERRORLEVEL 1 GOTO Label1
GOTO Label0 

:Label255
(commands to be executed at errorlevel 255)
GOTO End

	*
	*
	*

:Label1
(commands to be executed at errorlevel 1)
GOTO End

:Label0
(commands to be executed at errorlevel 0, or no errorlevel)

:End

This will result in many more lines of batch code, but at least it will work in any DOS version.

See http://www.robvander...errorlevel.html for more details.

[stettybet0]

Thanks! That worked.